- Notifications
You must be signed in to change notification settings - Fork752
Enable Travis Embedded Tests#391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
codecovbot commentedFeb 17, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #391 +/- ##====================================== Coverage 63.3% 63.3% ====================================== Files 60 60 Lines 5219 5219 Branches 859 859 ====================================== Hits 3304 3304 Misses 1695 1695 Partials 220 220
Continue to review full report at Codecov.
|
1d62c78 todf4cc07Compare2542de6 to2e885d1CompareAdd conditional class skip to pytuple for Travis/PY27Add individual filters to other tests as neededhttps://www.amido.com/code/conditional-ignore-nunit-and-the-ability-to-conditionally-ignore-a-test/http://stackoverflow.com/a/16075029/5208670
2e885d1 to55d4bbbCompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
What does this implement/fix? Explain your changes.
Enables embedded tests on Travis
Does this close any currently open issues?
Closes#224
Any other comments?
Enabling the test exposed a few bugs in PY2/PY3 pythonnet on Linux. I've opened tickets for a couple of them.
I've added the error messages to the tests and aconditional ignore testing. As the issues get fixed, the conditional on the tests can be removed.