NotificationsYou must be signed in to change notification settings
Fork752
Star5.1k

Fix Pyobject GC Finalize & Enable NUnit Exit Code#365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

vmuriart merged 3 commits intopythonnet:masterfromvmuriart:pyobject_finalize

Feb 8, 2017

Merged

Fix Pyobject GC Finalize & Enable NUnit Exit Code#365

vmuriart merged 3 commits intopythonnet:masterfromvmuriart:pyobject_finalize

Feb 8, 2017

Conversation

Copy link

Contributor

vmuriart commentedFeb 8, 2017•
edited
Loading

What does this implement/fix? Explain your changes.

Fixes random crashes on AppVeyor Embedded tests.
Specifically, fixes crashes when exiting a program.

Does this close any currently open issues?

Closes#364
Closes#262
Maybe#245

Any other comments?

Enables NUNIT's exit code to be part of the success criteria of the tests.
No new tests added since it affected all tests 👍

Checklist

Check all those that are applicable and complete.

Make sure to include one or more tests for your change
Add yourself toAUTHORS
Updated theCHANGELOG

vmuriart added2 commits

February 7, 2017 18:56

Turn on NUNIT exit code

75dd544

Fix GC on PyObject during Finalizing

c69297e

Similar to how `PythonDerivedType` finalizes.Closespythonnet#364Possibly related topythonnet#245

vmuriart requested review fromfilmor,tonyroberts andden-run-ai

February 8, 2017 02:07

Update CHANGELOG

c954442

Copy link

codecov-io commentedFeb 8, 2017•
edited by codecovbot
Loading

Codecov Report

Merging#365 intomaster willnot impact coverage.

@@           Coverage Diff           @@##           master     #365   +/-   ##=======================================  Coverage   62.72%   62.72%           =======================================  Files          61       61             Lines        5253     5253             Branches      876      876           =======================================  Hits         3295     3295             Misses       1740     1740             Partials      218      218

Impacted Files	Coverage Δ
src/runtime/pyobject.cs	`22.76% <100%> (ø)`	✅

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updated82ca28...c954442. Read thecomment docs.