- Notifications
You must be signed in to change notification settings - Fork752
Fix Console config, Add pyproj, Add PY3 to configurationmanager#346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecov-io commentedJan 31, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report@@ Coverage Diff @@## master #346 +/- ##=========================================- Coverage 61.55% 60.85% -0.7%========================================= Files 61 57 -4 Lines 5264 5089 -175 Branches 885 852 -33 =========================================- Hits 3240 3097 -143+ Misses 1805 1773 -32 Partials 219 219
Continue to review full report at Codecov.
|
1234e3a to8fe3f83Compare| @@ -31,7 +31,7 @@ install: | |||
| script: | |||
| - export PYTHONPATH=`pwd`:$PYTHONPATH | |||
| - python src/tests/runtests.py | |||
| # - nunit-console src/embed_tests/bin/x64/ReleaseMono/Python.EmbeddingTest.dll | |||
| # - nunit-console src/embed_tests/bin/Python.EmbeddingTest.dll | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why is this still commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It runs the tests but all sayCant find python.runtime error. Didn't have a chance to debug it. I'm keeping the tests paths updated though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Okay, fine by me then, but I'll open an issue for this, we should really start running those tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
On appveyor, when we run them on py3 they freeze and hang the testrunner until the build bot times out (30 minutes or so?).
I stress tested it on PY27 and its def fixed there. Ran 10 times no issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@filmor if we downgrade back to nunit2.6.2 we can start running the tests. They will still fail, but nunit will gracefully fail and give us the error instead of whatever nunit3 is doing now
Console had it owns set of properties going on
Corrected the configs, won't interfere with users without PTVS
Changed when consolidate output paths
Uh oh!
There was an error while loading.Please reload this page.
What does this implement/fix? Explain your changes.
Standardizes build configurations across the projects (
Console.csprojhad its own thing going on)Adds @denfromufa 's *.pyproj with corrected configurations