Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Project files tune-up#320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vmuriart merged 11 commits intopythonnet:masterfromvmuriart:cleanup-files
Jan 11, 2017
Merged

Conversation

@vmuriart
Copy link
Contributor

  • Maintenance to the project to remove many unneeded files. Commit history references when/why its safe to remove the files.
  • Added a CHANGELOG
  • Cleaned up project references to files
  • Cleaned up a couple warnings and tests

Overall it makes the project look alot less intimidating

@vmuriart
Copy link
ContributorAuthor

@tonyroberts what's the purpose ofclrmodule.il?

It looks like nothing references it anymore, and everything still passed after I removed it, but I didn't want to remove it since I couldn't understand its purpose.

@filmor
Copy link
Member

I like this PR a lot, keep going :)

@filmorfilmor mentioned this pull requestJan 9, 2017
9 tasks
@tonyroberts
Copy link
Contributor

@vmuriart re: clrmodule.il, I think this and related files (clrmodule.pp.il, oldmodule.il, buildclrmodule.bat) can be safely deleted. They're from before I started looking at this project, but from what I can gather they're legacy code that has since been replaced by clrmodule.cs.

@vmuriart
Copy link
ContributorAuthor

@vmuriart
Copy link
ContributorAuthor

I think thispr is ready for merging. There's still a bit more to clean-up within the src itself, but I don't want to mix those in with thispr.

Let me know if there's any objections with merging it in. For this particularpr I'd prefer we do amerge commit to a copy of commit messages since they explain the reasoning for each file deletion.

@vmuriartvmuriart mentioned this pull requestJan 9, 2017
- `./htdocs/*` duplicates the content of `pythonnet.github.io`- `./installer/*` isn't used for distribution anymore- `pythonnet.build` is no longer used as build method.- `*.{mds,,mdp}` are deprecated mono files. Deprecated sinceeff40df- `pythonnet_8.sln` old solution file- `pythonnet_9.sln` old solution file- `doc/mono_config.txt` outdate version of `.\Python.Runtime.dll.config`- `doc/Python.Runtime.dll.config` outdate version of `.\Python.Runtime.dll.config`- `visualstate` is a per user setting.https://groups.google.com/forum/#!topic/nunit-discuss/7aXg_usr98Q
Relevant items from todo.txt were opened as tickets
`sourceforge-logo.png` not sure why it existed`clrmodule.pp.il` used to be part of the makefile build to create `clrmodule.il`. No longer used.`oldmodule.il` is an old copy of `clrmodule.il` commit:927bbf1
- Add reference to py3.3 and py3.6 interop files- Add missing preprocessor to py3.3 interop- Remove unused build script. Unref on commit:5300343Note, looks like nothing uses `clrmodule.il` anymore. Leaving it for now.
- Remove py32 classifier- Stop testing on unsupported python versions- Add python33 testing- Changed check_output to _check_output
> warning : The project configuration for project 'clrmodule' corresponding to the solution configuration 'ReleaseMono|x64' was not found.
@vmuriart
Copy link
ContributorAuthor

@denfromufa@filmor@tonyroberts any objections to merging this in?

@filmor
Copy link
Member

Is it fine to merge this squashed?

@vmuriartvmuriart merged commit5f6e16c intopythonnet:masterJan 11, 2017
@vmuriartvmuriart deleted the cleanup-files branchJanuary 11, 2017 21:18
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@filmorfilmorfilmor approved these changes

@den-run-aiden-run-aiAwaiting requested review from den-run-ai

+1 more reviewer

@tonyrobertstonyrobertstonyroberts approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vmuriartvmuriart

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vmuriart@filmor@tonyroberts

[8]ページ先頭

©2009-2025 Movatter.jp