- Notifications
You must be signed in to change notification settings - Fork749
Addresses issue #261 with providing more detail information missing d…#298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…missing dependencies with ImportError Exceptions
@fdanny can you please add some tests? i.e. you can look at test_import.py file. |
@denfromufa Yup. I can do that. The way I tested it I created a dll that had a missing dependency. I made assure my ImportError Exception contained the specific missing dependency. Is this something that you were thinking? |
Yes, that's right! …On Thu, Dec 1, 2016, 4:35 PM fdanny ***@***.***> wrote: @denfromufa <https://github.com/denfromufa> Yup. I can do that. The way I tested it I created a dll that had a missing dependency. I made assure my ImportError Exception contained the specific missing dependency. Is this something that you were thinking? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#298 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgZ5YsE4jQuzGb5kQDIvm6IfkH2FZ7Uks5rD0vNgaJpZM4LB5fw> . |
Contributor
den-run-ai left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you make TestDependencyAssembly.dll compile as part of project and remove its dependencies before import? Just including a binary without source code is not maintainable.
ContributorAuthor
fdanny commentedDec 2, 2016 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@denfromufa Is there a location in the solution you want me to put this in TestDependencyAssembly? Is it okay just to check the solution as a reference and treat this dll as a resource. If there are any changes needed then the source code is included to build Also why did my test failed on the Travis CI but passed AppVeyor? It has the following error |
You can just add a new project to solution. Otherwise just compile at That dll loading issue is pretty weird, please share the source code and Here is repeatable issue using Mono C# REPL when using reflection, but not |
ContributorAuthor
fdanny commentedDec 6, 2016 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@denfromufa I ran into an issue trying to resolve this. My method will only work if the namespace imported is the same as the assembly name. I have no way of mapping a namespace to an assembly. It looks like when The issue in ScanAssembly is when This doesn't work since it doesn't have all the dependencies so we don't get the namespace mapping. I'm thinking the following maybe
What do you think??? |
@fdanny maybe it is ok without namespace in the error message? but i'm surprised that it is hard to track it down. |
@denfromufa@fdanny is there any help needed for this |
@fdanny needs help tracking down the namespace name in the Exception traceback |
lostmsu added a commit to losttech/pythonnet that referenced this pull requestMar 4, 2020
…ore info when CLR assemblies are failed to be loaded1. When trying to implicitly load assemblies, and that fails NOT because an assembly is missing, but because loading failed for some reason, emit Python warning.2. When trying to import a module in our import hook, if the module name is an assembly name, and we fail to load it, and Python also fails to find a module with the same name, add the exceptions we got during the attempt to load it into __cause__ of the final ImportErrorBREAKING: clr.AddReference will now throw exceptions besides FileNotFoundException.Additional: a few uses of BorrowedReferenceThis addressespythonnet#261It is an alternative topythonnet#298
2 tasks
lostmsu added a commit to losttech/pythonnet that referenced this pull requestMar 4, 2020
…ore info when CLR assemblies are failed to be loaded1. When trying to implicitly load assemblies, and that fails NOT because an assembly is missing, but because loading failed for some reason, emit Python warning.2. When trying to import a module in our import hook, if the module name is an assembly name, and we fail to load it, and Python also fails to find a module with the same name, add the exceptions we got during the attempt to load it into __cause__ of the final ImportErrorBREAKING: clr.AddReference will now throw exceptions besides FileNotFoundException.Additional: a few uses of BorrowedReferenceThis addressespythonnet#261It is an alternative topythonnet#298
lostmsu added a commit to losttech/pythonnet that referenced this pull requestApr 23, 2020
…ore info when CLR assemblies are failed to be loaded1. When trying to implicitly load assemblies, and that fails NOT because an assembly is missing, but because loading failed for some reason, emit Python warning.2. When trying to import a module in our import hook, if the module name is an assembly name, and we fail to load it, and Python also fails to find a module with the same name, add the exceptions we got during the attempt to load it into __cause__ of the final ImportErrorBREAKING: clr.AddReference will now throw exceptions besides FileNotFoundException.Additional: a few uses of BorrowedReferenceThis addressespythonnet#261It is an alternative topythonnet#298
lostmsu added a commit to losttech/pythonnet that referenced this pull requestApr 27, 2020
…ore info when CLR assemblies are failed to be loaded1. When trying to implicitly load assemblies, and that fails NOT because an assembly is missing, but because loading failed for some reason, emit Python warning.2. When trying to import a module in our import hook, if the module name is an assembly name, and we fail to load it, and Python also fails to find a module with the same name, add the exceptions we got during the attempt to load it into __cause__ of the final ImportErrorBREAKING: clr.AddReference will now throw exceptions besides FileNotFoundException.Additional: a few uses of BorrowedReferenceThis addressespythonnet#261It is an alternative topythonnet#298
lostmsu added a commit to losttech/pythonnet that referenced this pull requestMay 13, 2020
…ore info when CLR assemblies are failed to be loaded1. When trying to implicitly load assemblies, and that fails NOT because an assembly is missing, but because loading failed for some reason, emit Python warning.2. When trying to import a module in our import hook, if the module name is an assembly name, and we fail to load it, and Python also fails to find a module with the same name, add the exceptions we got during the attempt to load it into __cause__ of the final ImportErrorBREAKING: clr.AddReference will now throw exceptions besides FileNotFoundException.Additional: a few uses of BorrowedReferenceThis addressespythonnet#261It is an alternative topythonnet#298
lostmsu added a commit to losttech/pythonnet that referenced this pull requestAug 18, 2020
…ore info when CLR assemblies are failed to be loaded1. When trying to implicitly load assemblies, and that fails NOT because an assembly is missing, but because loading failed for some reason, emit Python warning.2. When trying to import a module in our import hook, if the module name is an assembly name, and we fail to load it, and Python also fails to find a module with the same name, add the exceptions we got during the attempt to load it into __cause__ of the final ImportErrorBREAKING: clr.AddReference will now throw exceptions besides FileNotFoundException.Additional: a few uses of BorrowedReferenceThis addressespythonnet#261It is an alternative topythonnet#298
lostmsu added a commit to losttech/pythonnet that referenced this pull requestAug 18, 2020
…ore info when CLR assemblies are failed to be loaded1. When trying to implicitly load assemblies, and that fails NOT because an assembly is missing, but because loading failed for some reason, emit Python warning.2. When trying to import a module in our import hook, if the module name is an assembly name, and we fail to load it, and Python also fails to find a module with the same name, add the exceptions we got during the attempt to load it into __cause__ of the final ImportErrorBREAKING: clr.AddReference will now throw exceptions besides FileNotFoundException.Additional: a few uses of BorrowedReferenceThis addressespythonnet#261It is an alternative topythonnet#298
lostmsu added a commit to losttech/pythonnet that referenced this pull requestAug 18, 2020
…ore info when CLR assemblies are failed to be loaded1. When trying to implicitly load assemblies, and that fails NOT because an assembly is missing, but because loading failed for some reason, emit Python warning.2. When trying to import a module in our import hook, if the module name is an assembly name, and we fail to load it, and Python also fails to find a module with the same name, add the exceptions we got during the attempt to load it into __cause__ of the final ImportErrorBREAKING: clr.AddReference will now throw exceptions besides FileNotFoundException.Additional: a few uses of BorrowedReferenceThis addressespythonnet#261It is an alternative topythonnet#298
lostmsu added a commit to losttech/pythonnet that referenced this pull requestAug 18, 2020
…ore info when CLR assemblies are failed to be loaded1. When trying to implicitly load assemblies, and that fails NOT because an assembly is missing, but because loading failed for some reason, emit Python warning.2. When trying to import a module in our import hook, if the module name is an assembly name, and we fail to load it, and Python also fails to find a module with the same name, add the exceptions we got during the attempt to load it into __cause__ of the final ImportErrorBREAKING: clr.AddReference will now throw exceptions besides FileNotFoundException.Additional: a few uses of BorrowedReferenceThis addressespythonnet#261It is an alternative topythonnet#298
lostmsu added a commit to losttech/pythonnet that referenced this pull requestAug 18, 2020
…ore info when CLR assemblies are failed to be loaded1. When trying to implicitly load assemblies, and that fails NOT because an assembly is missing, but because loading failed for some reason, emit Python warning.2. When trying to import a module in our import hook, if the module name is an assembly name, and we fail to load it, and Python also fails to find a module with the same name, add the exceptions we got during the attempt to load it into __cause__ of the final ImportErrorBREAKING: clr.AddReference will now throw exceptions besides FileNotFoundException.Additional: a few uses of BorrowedReferenceThis addressespythonnet#261It is an alternative topythonnet#298
lostmsu added a commit that referenced this pull requestAug 19, 2020
…ore info when CLR assemblies are failed to be loaded1. When trying to implicitly load assemblies, and that fails NOT because an assembly is missing, but because loading failed for some reason, emit Python warning.2. When trying to import a module in our import hook, if the module name is an assembly name, and we fail to load it, and Python also fails to find a module with the same name, add the exceptions we got during the attempt to load it into __cause__ of the final ImportErrorBREAKING: clr.AddReference will now throw exceptions besides FileNotFoundException.Additional: a few uses of BorrowedReferenceThis addresses#261It is an alternative to#298
The alternative PR#1076 was merged a while ago. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses issue#261 to provide more information when there is a missing assembly dependency. The logic basically does the following