NotificationsYou must be signed in to change notification settings
Fork750
Star5.1k

Py3 comparison operators#291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

ArvidJB wants to merge9 commits intopythonnet:masterfromArvidJB:py3_compare

Closed

Py3 comparison operators#291

ArvidJB wants to merge9 commits intopythonnet:masterfromArvidJB:py3_compare

Conversation

Copy link

Contributor

ArvidJB commentedNov 16, 2016•
edited
Loading

Looks like <, <=, >, >= implementations were dropped when moving from Python 2 to 3.

abessenand others added8 commits

November 16, 2016 09:14

Do not call Decref if self.repr is still IntPtr.Zero

68e81c7

Same self.repr null check in ConstructorBinding.tp_dealloc

60c5a96

Rename Runtime.Incref/Decref to XIncref/XDecref to signal that they c…

81958b2

…heck for NULLRemove NULL check debug print in DecrefRemove added NULL checks for self.repr in constructorbinding.cs

Add missing changes for Python 2

1445a79

Implement comparison operations

c40d859

Merge branch 'master' into py3_compare

649fcbd

Disable tests for Python 2

81e9d61

Merge remote-tracking branch 'ArvidJB_pythonnet/py3_compare' into py3…

233b2da

…_compare

Copy link

ContributorAuthor

ArvidJB commentedNov 16, 2016

Actually the implementation of <, <=, >, >= seems to be broken for Python 2: it always returns -1:
if (Object.Equals(o1, o2)) { return 0; } return -1;
I've disabled the tests I added for Python 2...

Merge branch 'master' into py3_compare

4b5ae6d

Copy link

Member

filmor commentedNov 23, 2016

If you'd cherry-pickb709a4b on top we will use the same code for Python 2 and 3, so Py2 will also benefit from your change.tp_compare has been obsoleted bytp_richcompare a long time ago.