- Notifications
You must be signed in to change notification settings - Fork766
2574 StackOverflow Exception On Super Method Call Fix#2628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
2574 StackOverflow Exception On Super Method Call Fix#2628
Conversation
…ning a method and some not.Also fixed an issue causing the finalizer to be called twice.Added unit tests to verify the fix.
3ddd76a
tobf389cf
CompareThanks a lot for this. I will try my best to get the CI working again on the weekend and will "enqueue" this one for merging. |
rmadsen-ks commentedOct 9, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I have added the actual fix for#2574. In this case, it did not find the correct method to call the base class variant of the virtual method called. Instead it decided to call the top function, causing a stack overflow exception. This has been fixed by using the correct name for the base class function invoke method I think this is ready for merge, but I will continue testing it. |
Uh oh!
There was an error while loading.Please reload this page.
Update: Does not actuallyfix#2574, but a similar problem(#2629). I'll provide a fix for 2574 as well.Update 2: Now this alsofixes#2574
This fixed an issue with a StackOverflow exception being generated when a virtual method is being called, but a class in the middle of the inheritance tree does not override the method.
This happens because the CallVirtual method calls the method on the python object if the wrapper got generated, causing everything to be evaluated again from the top. Doing it this way, causes the the python method only to get invoked if there is an implementation on the class, which can then correctly call
super().Method()
.For the finalizer fix, we now skip generating the call to PyFinalize if the base class is already a python class, because if that is the case the finalize method has already been added.
Additionally it simplifies how the generated code for virtual methods look. Now, a virtual wrapper method is not automatically generated. Only if the method is actually being overwritten by the class it will prompt the generation of a virtual method wrapper.
Does this close any currently open issues?
Thiscloses#2574,#2627,#2629
Any other comments?
...
Checklist
Check all those that are applicable and complete.
AUTHORS
CHANGELOG