Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

2574 StackOverflow Exception On Super Method Call Fix#2628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
rmadsen-ks wants to merge3 commits intopythonnet:master
base:master
Choose a base branch
Loading
fromrmadsen-ks:2574-StackOverFlowExceptionOnSuperMethodCallFix

Conversation

@rmadsen-ks
Copy link
Contributor

@rmadsen-ksrmadsen-ks commentedOct 9, 2025
edited
Loading

Update: Does not actuallyfix#2574, but a similar problem(#2629). I'll provide a fix for 2574 as well.
Update 2: Now this alsofixes#2574
This fixed an issue with a StackOverflow exception being generated when a virtual method is being called, but a class in the middle of the inheritance tree does not override the method.

This happens because the CallVirtual method calls the method on the python object if the wrapper got generated, causing everything to be evaluated again from the top. Doing it this way, causes the the python method only to get invoked if there is an implementation on the class, which can then correctly callsuper().Method().

For the finalizer fix, we now skip generating the call to PyFinalize if the base class is already a python class, because if that is the case the finalize method has already been added.

Additionally it simplifies how the generated code for virtual methods look. Now, a virtual wrapper method is not automatically generated. Only if the method is actually being overwritten by the class it will prompt the generation of a virtual method wrapper.

Does this close any currently open issues?

Thiscloses#2574,#2627,#2629

Any other comments?

...

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Ensure you have signed the.NET Foundation CLA
  • Add yourself toAUTHORS
  • Updated theCHANGELOG

@rmadsen-ksrmadsen-ksforce-pushed the2574-StackOverFlowExceptionOnSuperMethodCallFix branch from3ddd76a tobf389cfCompareOctober 9, 2025 08:30
@filmor
Copy link
Member

Thanks a lot for this. I will try my best to get the CI working again on the weekend and will "enqueue" this one for merging.

@rmadsen-ks
Copy link
ContributorAuthor

rmadsen-ks commentedOct 9, 2025
edited
Loading

I have added the actual fix for#2574.

In this case, it did not find the correct method to call the base class variant of the virtual method called. Instead it decided to call the top function, causing a stack overflow exception.

This has been fixed by using the correct name for the base class function invoke method

I think this is ready for merge, but I will continue testing it.

filmor reacted with thumbs up emoji

…ning a method and some not.Also fixed an issue causing the finalizer to be called twice.Added unit tests to verify the fix.
@filmorfilmorforce-pushed the2574-StackOverFlowExceptionOnSuperMethodCallFix branch froma3fbc84 to98a740eCompareDecember 8, 2025 10:29
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

StackOverflowException on calling super().method()

2 participants

@rmadsen-ks@filmor

[8]ページ先頭

©2009-2025 Movatter.jp