- Notifications
You must be signed in to change notification settings - Fork773
Non-breaking workaround for BinaryFormatter deprecation, issue #2469#2621
Non-breaking workaround for BinaryFormatter deprecation, issue #2469#2621Legion-ale wants to merge 2 commits intopythonnet:masterfrom
Conversation
Legion-ale left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
; wrongly deleted when celaning function. Now build correctly
Legion-ale commentedSep 30, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I see that the errors are:
Is not something I Implemented... so i didn't commit my changes at the .csproj, but i think is enought to edit to latest .NET LTS: Link to MS versioning: https://dotnet.microsoft.com/en-us/platform/support/policy Am I missing something? Can i commit the project edit? |
filmor commentedOct 1, 2025
filmor commentedOct 21, 2025
#2639 should do this without trying to parse the version. Thank you for your effort! |
Legion-ale commentedOct 22, 2025
Ok, i see the#2639 commit and it should work. |
filmor commentedOct 22, 2025
Thanks, I'll change it accordingly. For |
What does this implement/fix? Explain your changes.
non-breaking change that fix BinaryFormatter deprecation on .Net9.0 and higher
Does this close any currently open issues?
yes#2469
Any other comments?
Considering that NoopFormatter exists in the code you're probably working on it, that are my 2 cents.