- Notifications
You must be signed in to change notification settings - Fork773
Add context manager protocol for .NET IDisposable types#2568
Open
den-run-ai wants to merge 4 commits intopythonnet:masterfrom
Open
Add context manager protocol for .NET IDisposable types#2568den-run-ai wants to merge 4 commits intopythonnet:masterfrom
den-run-ai wants to merge 4 commits intopythonnet:masterfrom
Conversation
Member
lostmsu commentedMar 24, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
FYI: tests are not passing |
ContributorAuthor
den-run-ai commentedMar 24, 2025
This seems not related to this PR@lostmsu i tested on mac with .net 8 |
Member
lostmsu commentedApr 11, 2025
@den-run-ai This is definitely related to PR, master does not seem to be failing these tests. |
michaelblyons commentedMay 1, 2025
For anyone else who is annoyed that the test failures do not provoke backtraces on GitHub's UI,1 here is the output: My (uninitiated) interpretation is that some cruft is left hanging around despite the Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Implemented IDisposable based on this discussion:
#79
@microsoft-github-policy-service agree
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG