- Notifications
You must be signed in to change notification settings - Fork749
Try to be strict around non-copyability#2440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -103,5 +103,6 @@ public static PyFloat AsFloat(PyObject value) | |||
| public double ToDouble() => Runtime.PyFloat_AsDouble(obj); | |||
| public override TypeCode GetTypeCode() => TypeCode.Double; | |||
| public override int GetHashCode() => ((PyObject)this).GetHashCode(); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This looks like it would just stackoverflow
| @@ -232,5 +232,6 @@ public string ToString(string format, IFormatProvider formatProvider) | |||
| } | |||
| public override TypeCode GetTypeCode() => TypeCode.Int64; | |||
| public override int GetHashCode() => ((PyObject)this).GetHashCode(); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Same
| var free = (delegate* unmanaged[Cdecl]<refStolenReference, void>)freePtr; | ||
| free(refob); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think this is wrong. It does not say anywhere but I'd expecttp_free to take a reference toPyObject (e.g.PyObject*), not a reference to reference to it (e.g. not aPyObject**).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ah, that's probably one reason for the crashes :)
Uh oh!
There was an error while loading.Please reload this page.
Seems abandoned - requested changes not addressed. |
Not abandoned, just very low priority. We have to fix these warnings eventually, they are extremely spammy and the non-copyability check is borderline useless right now. Either we fix things or we drop the analyzer until an official one is added. |
No description provided.