- Notifications
You must be signed in to change notification settings - Fork773
Conversation
| public double ToDouble() => Runtime.PyFloat_AsDouble(obj); | ||
| public override TypeCode GetTypeCode() => TypeCode.Double; | ||
| public override int GetHashCode() => ((PyObject)this).GetHashCode(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This looks like it would just stackoverflow
| } | ||
| public override TypeCode GetTypeCode() => TypeCode.Int64; | ||
| public override int GetHashCode() => ((PyObject)this).GetHashCode(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Same
| var free = (delegate* unmanaged[Cdecl]<refStolenReference, void>)freePtr; | ||
| free(refob); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think this is wrong. It does not say anywhere but I'd expecttp_free to take a reference toPyObject (e.g.PyObject*), not a reference to reference to it (e.g. not aPyObject**).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ah, that's probably one reason for the crashes :)
Uh oh!
There was an error while loading.Please reload this page.
lostmsu commentedApr 11, 2025
Seems abandoned - requested changes not addressed. |
filmor commentedApr 14, 2025
Not abandoned, just very low priority. We have to fix these warnings eventually, they are extremely spammy and the non-copyability check is borderline useless right now. Either we fix things or we drop the analyzer until an official one is added. |
No description provided.