- Notifications
You must be signed in to change notification settings - Fork748
Fix crash when event does not haveAdd
method and improve message for some other internal errors#2409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
As said, while looking mildly prettier, this still renders the library completely useless in this case. I don't think there is any valid reason for us to bail out on init just because a single type is not loaded properly. So, sure, we can merge this, but we can not claim that it fixes the reported issue. |
lostmsu commentedJul 2, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@filmor the fix is the new null check in The rest is to make it easier to do bug reports: the error data will now at least contain the name of the type that we failed to process. |
I see. Still don't see why making |
9ebfbde
intopythonnet:masterUh oh!
There was an error while loading.Please reload this page.
@filmor it does not swallow the error. The checks on methods and fields are different. They actually check that method or field was passed, and not just BTW I was unable to reproduce it with C#. |
What does this implement/fix? Explain your changes.
AddMethod
InternalPythonnetException
that can tell user what .NET type caused failure if an unexpected internal error occursDoes this close any currently open issues?
#2405
Checklist
Check all those that are applicable and complete.
CHANGELOG