- Notifications
You must be signed in to change notification settings - Fork748
IComparable
andIEquatable
implementations#2322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
filmor approved these changesFeb 28, 2024
Regarding the GIL, maybe we could a custom thread local ref count could speed things up? |
3e27819
tof3d8c60
Compare…String for primitive .NET types
ebab183
tof738505
CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
IComparable
andIEquatable
implementations forPyInt
,PyFloat
, andPyString
for primitive .NET typesWhat does this implement/fix? Explain your changes.
Let's one do
PyInt.CompareTo(42)
and similar thingsDoes this close any currently open issues?
N/A
Any other comments?
Should we take GIL in these methods? Might be useful for
Array.Sort
when called from Python.On a more general topic: should we have a way for Python to call a .NET method and have it not release the GIL for compatibility with 3rd party (to Python.NET) libraries that assume they can call back any methods they wish at any time. Because having explicit GIL acquisition in
CompareTo
to use withArray.Sort
would kill performance. E.g. something like:Checklist
Check all those that are applicable and complete.
AUTHORS
CHANGELOG