Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Explicitly compare MaybeType objects by name#2270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
filmor wants to merge1 commit intomaster
base:master
Choose a base branch
Loading
fromcompare-maybetype-by-name

Conversation

filmor
Copy link
Member

What does this implement/fix? Explain your changes.

As observed by@rayfalling, multiple instances ofReflectedType values might be created in the cache, leading to crashes during stashing.

@rayfalling, could you provide a test-case for this?

Does this close any currently open issues?

#2269

Any other comments?

...

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Ensure you have signed the.NET Foundation CLA
  • Add yourself toAUTHORS
  • Updated theCHANGELOG

@rayfalling
Copy link

rayfalling commentedOct 18, 2023•
edited
Loading

What I meet is a Unity Project with FingerGesture plugin
I will prepare Unity Project test case tomorrow
It's nine o'clock in the evening now, I need to get off work first :)

@filmorfilmorforce-pushed thecompare-maybetype-by-name branch from4195f16 to4bb5e6bCompareOctober 18, 2023 13:53
@rayfalling
Copy link

This is the test-case.
You can open it in Unity 2019.4.38f1
minimalTest.zip

@lostmsu
Copy link
Member

lostmsu commentedNov 7, 2023•
edited
Loading

Do you know circumstances under which this happens? What is the scenario when we can have two differentMaybeType with the same name? Perhaps this is what needs to be prevented instead.

@filmorfilmorforce-pushed thecompare-maybetype-by-name branch from4bb5e6b to536c341CompareSeptember 19, 2024 17:54
@filmorfilmorforce-pushed thecompare-maybetype-by-name branch from536c341 tobccee2cCompareSeptember 19, 2024 18:05
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@filmor@rayfalling@lostmsu
[8]ページ先頭
©2009-2025 Movatter.jp