Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Python 3.12#2249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
filmor merged 8 commits intomasterfrompython-3.12
Oct 6, 2023
Merged

Python 3.12#2249

filmor merged 8 commits intomasterfrompython-3.12
Oct 6, 2023

Conversation

filmor
Copy link
Member

  • Add type offsets for 3.12 and update interop generation
  • Drop unused custom incref/decref
  • Add 3.12 to CI and metadata

@filmor
Copy link
MemberAuthor

@lostmsu Can you have a look in particular at1bcf218? I'm not quite sure what exactly you are testing here but it doesn't work on 3.12 anymore.

raulcd pushed a commit to apache/arrow that referenced this pull requestOct 3, 2023
### Rationale for this changeThe conda-integration build has recently started failing:https://github.com/apache/arrow/actions/runs/6393852866/job/17353952453Apparently this is because conda-forge is now providing Python 3.12 by default, and pythonnet [does not support it yet](pythonnet/pythonnet#2249).### What changes are included in this PR?Avoid using Python 3.12 for Archery in conda-integration build.### Are these changes tested?Yes, by construction.### Are there any user-facing changes?No.*Closes:#37993Authored-by: Antoine Pitrou <antoine@python.org>Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
@lostmsu
Copy link
Member

Please take the commit fromhttps://github.com/losttech/pythonnet/tree/instanceless-explicit to change the test. If it still does not raise in 3.12, keep the version guard and refer topython/cpython#101578

@filmorfilmorforce-pushed thepython-3.12 branch 2 times, most recently from53a8341 tof988251CompareOctober 3, 2023 20:21
@filmor
Copy link
MemberAuthor

Same result. It actually does raise, but the reference check forPyErr fails and it doesn't convert it.

@lostmsu
Copy link
Member

On Python 3.12 I think it should raise an instance ofStopIteration. Prior to 3.12 that would be an exception with typeStopIteration but without instance, which is what decoder was handling. E.g. if you replace the check for the wrapper with a check forStopIteration instance in 3.12, that should do it.

@filmor
Copy link
MemberAuthor

Well, that's not what this one is testing, though. I'll keep it deactivated for now. If the rest is fine with you, I'll merge it and cut a new version (maybe after having another look at#2245).

@filmorfilmor merged commit88418da intomasterOct 6, 2023
@filmorfilmor deleted the python-3.12 branchOctober 6, 2023 10:56
@lostmsu
Copy link
Member

lostmsu commentedOct 6, 2023•
edited
Loading

Well, that's not what this one is testing, though.

👍I can fix the test as I outlined above. My understanding is that 3.12 always normalizes exceptions while 3.11 and before did not.

E.g.throw new PythonException(stopIteration, value: null, traceback: null) (and the original iteration over an empty list) would end up raising a Python error with typeStopIteration andNone value in 3.11 and before, while 3.12 will automatically callStopIteration constructor in this case and set exception value to the resulting instance.

The decoder is needed in 3.11 and before because otherwise you have no way in C# to catchNone exception value.

JerAguilon pushed a commit to JerAguilon/arrow that referenced this pull requestOct 23, 2023
### Rationale for this changeThe conda-integration build has recently started failing:https://github.com/apache/arrow/actions/runs/6393852866/job/17353952453Apparently this is because conda-forge is now providing Python 3.12 by default, and pythonnet [does not support it yet](pythonnet/pythonnet#2249).### What changes are included in this PR?Avoid using Python 3.12 for Archery in conda-integration build.### Are these changes tested?Yes, by construction.### Are there any user-facing changes?No.*Closes:apache#37993Authored-by: Antoine Pitrou <antoine@python.org>Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull requestNov 13, 2023
### Rationale for this changeThe conda-integration build has recently started failing:https://github.com/apache/arrow/actions/runs/6393852866/job/17353952453Apparently this is because conda-forge is now providing Python 3.12 by default, and pythonnet [does not support it yet](pythonnet/pythonnet#2249).### What changes are included in this PR?Avoid using Python 3.12 for Archery in conda-integration build.### Are these changes tested?Yes, by construction.### Are there any user-facing changes?No.*Closes:apache#37993Authored-by: Antoine Pitrou <antoine@python.org>Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
@AlexCatarinoAlexCatarino mentioned this pull requestJan 26, 2024
4 tasks
dgreiss pushed a commit to dgreiss/arrow that referenced this pull requestFeb 19, 2024
### Rationale for this changeThe conda-integration build has recently started failing:https://github.com/apache/arrow/actions/runs/6393852866/job/17353952453Apparently this is because conda-forge is now providing Python 3.12 by default, and pythonnet [does not support it yet](pythonnet/pythonnet#2249).### What changes are included in this PR?Avoid using Python 3.12 for Archery in conda-integration build.### Are these changes tested?Yes, by construction.### Are there any user-facing changes?No.*Closes:apache#37993Authored-by: Antoine Pitrou <antoine@python.org>Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@filmor@lostmsu
[8]ページ先頭
©2009-2025 Movatter.jp