Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

FixGetBuffer throwingArgumentOutOfRangeException#2120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lostmsu merged 3 commits intopythonnet:masterfromlegomanww:fix/bufferlen
Mar 12, 2023

Conversation

legomanww
Copy link
Contributor

What does this implement/fix? Explain your changes.

PyBuffer throwsSystem.ArgumentOutOfRangeException when trying to useGetBuffer() with anything other thanPyBUF.SIMPLE since theMarshal.Copy calls had a typos so it was trying to copyshape,strides, andsuboffsets as arrays that were the full length of the source array instead of lengthndim.

Does this close any currently open issues?

no

Any other comments?

...

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Ensure you have signed the.NET Foundation CLA <- doesn't seem to be working
  • Add yourself toAUTHORS
  • Updated theCHANGELOG

@lostmsu
Copy link
Member

NIT: add parameter names toCopy calls (e.g.length: ...). Would be easier to spot the mistake next time.

legomanww reacted with thumbs up emoji

@lostmsulostmsu merged commit131b466 intopythonnet:masterMar 12, 2023
@legomanwwlegomanww deleted the fix/bufferlen branchMarch 13, 2023 00:32
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@filmorfilmorfilmor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@legomanww@lostmsu@filmor

[8]ページ先頭

©2009-2025 Movatter.jp