- Notifications
You must be signed in to change notification settings - Fork748
Remove suggestions to useinternal functions#2092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| When finished using Python APIs, managed code must call a corresponding | ||
| ``PythonEngine.ReleaseLock`` to release the GIL and allow other threads | ||
| to use Python. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
IMHO, "when finished" section needs corresponding replacement (maybe merged with the acquisition part).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I could see this being confusing a bit in regards with "disposing the return value" - as in "previously returned value" vs "callPy.GIL().Dispose() to release, but probably everyone would read it correctly.
Fixes#2091.
What does this implement/fix? Explain your changes.
...
Does this close any currently open issues?
...
Any other comments?
...
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG