- Notifications
You must be signed in to change notification settings - Fork752
Use msbuild tools from PATH if available#208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
related: |
| @@ -22,6 +23,10 @@ | |||
| def _find_msbuild_tool(tool="msbuild.exe", use_windows_sdk=False): | |||
| path = find_executable(tool) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This should be below the docstring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Oh my god how did that happen 😮 Silly me.
While _find_msbuild_tool searches in the registry to find the givenbuild tool, it doesn't check if it's already in PATH.If one uses a developer command prompt to build, all necessary tools arein PATH.Fixespythonnet#207 for me
@denfromufa I fixed the docstring issue. Can this be merged or is something else missing? |
@rnestler actually it is@tonyroberts who is merging pull requests for pythonnet. I'm ordinary contributor like you are :) |
@rnestler looks fine - but the Appveyor CI tests aren't working right now, so I need to fix that before I can merge this PR. |
@tonyroberts I activated AppVeyor CI onmy fork. It seems to build fine there:https://ci.appveyor.com/project/rnestler/pythonnet/build/1.0.2 |
While _find_msbuild_tool searches in the registry to find the given
build tool, it doesn't check if it's already in PATH.
If one uses a developer command prompt to build, all necessary tools are
in PATH.
Fixes#207 for me