- Notifications
You must be signed in to change notification settings - Fork767
Update unmanaged exports#206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
tonyroberts commentedJun 23, 2016
I had to fix the project file for this as well - it's not enough to just update packages.config. Please test your changes before creating pull requests and then pestering me to merge them. |
den-run-ai commentedJun 23, 2016
Well, I tested locally and did not notice until later time, but had no On Thursday, June 23, 2016, Tony Robertsnotifications@github.com wrote:
|
tonyroberts commentedJun 23, 2016
Pull requests are a request for code to be pulled (hence the name). There is no need to comment requesting that the code be pulled, as that's the purpose of a pull request! Code that is not ready to be pulled should be worked on in your own fork, preferably in a topic branch if it's anything other than a simple change. |
matthid commentedJun 23, 2016
@tonyroberts people often use PRs to check the state of CI (I do occasionally as well) without the need to test on a linux system for example. They are often marked as WIP and give you the opportunity to comment / discuss early on. |
tonyroberts commentedJun 23, 2016
Sure, I've no problem with that if clearly marked. I don't think that was the case here though, it was just something that didn't get picked up because the appveyor build didn't run. Personally, I have my own CI jobs set up against my own fork, but that's just my preference. |
#95