Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update unmanaged exports#206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tonyroberts merged 1 commit intopythonnet:masterfromden-run-ai:patch-12
Jun 23, 2016
Merged

Conversation

@den-run-ai
Copy link
Contributor

@den-run-aiden-run-ai changed the titleUpdate packages.configUpdate unmanaged exportsMay 27, 2016
@tonyrobertstonyroberts merged commitec6ebd1 intopythonnet:masterJun 23, 2016
@tonyroberts
Copy link
Contributor

I had to fix the project file for this as well - it's not enough to just update packages.config. Please test your changes before creating pull requests and then pestering me to merge them.

@den-run-ai
Copy link
ContributorAuthor

Well, I tested locally and did not notice until later time, but had no
opportunity to correct this pull request at that time.
Can you show any comment where I asked to merge my unfinished pull
request(s)?
Sorry for pestering you, but other people were waiting for some fixes in
master and last time you replied was about 2 months ago.

On Thursday, June 23, 2016, Tony Robertsnotifications@github.com wrote:

I had to fix the project file for this as well - it's not enough to just
update packages.config. Please test your changes before creating pull
requests and then pestering me to merge them.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#206 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AHgZ5Vntx4gz200mYHevnT7xpM7MR4H4ks5qOkrNgaJpZM4IK8dh
.

@tonyroberts
Copy link
Contributor

Pull requests are a request for code to be pulled (hence the name). There is no need to comment requesting that the code be pulled, as that's the purpose of a pull request! Code that is not ready to be pulled should be worked on in your own fork, preferably in a topic branch if it's anything other than a simple change.

@matthid
Copy link
Contributor

@tonyroberts people often use PRs to check the state of CI (I do occasionally as well) without the need to test on a linux system for example. They are often marked as WIP and give you the opportunity to comment / discuss early on.

@tonyroberts
Copy link
Contributor

Sure, I've no problem with that if clearly marked. I don't think that was the case here though, it was just something that didn't get picked up because the appveyor build didn't run. Personally, I have my own CI jobs set up against my own fork, but that's just my preference.

@den-run-aiden-run-ai deleted the patch-12 branchJune 23, 2016 12:27
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@den-run-ai@tonyroberts@matthid

[8]ページ先頭

©2009-2025 Movatter.jp