Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix implementing a generic interface with a Python class#1998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@filmor
Copy link
Member

@filmorfilmor commentedNov 2, 2022•
edited by lostmsu
Loading

What does this implement/fix? Explain your changes.

#1982

Does this close any currently open issues?

...

Any other comments?

...

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Ensure you have signed the.NET Foundation CLA
  • Add yourself toAUTHORS
  • Updated theCHANGELOG

@filmor
Copy link
MemberAuthor

@lostmsu Do you have a hint what to do here? The issue is thatMarshalByRefsBack callsMethodBase.GetMethodFromHandle(methodHandle) without also passing aRuntimeTypeHandle. Where would we get this type handle from?

@lostmsu
Copy link
Member

lostmsu commentedNov 2, 2022•
edited
Loading

@filmor I seem to be able to push directly to your repository o-O which I discovered trying to answer your question.

since RuntimeMethodHandle does not encode generic arguments, I had to supply RuntimeTypeHandle of the declaring type to be able to get fully specified method
@lostmsulostmsuforce-pushed thefix-derived-generic-interface branch from522e21a to5c1e02fCompareNovember 2, 2022 18:27
@filmor
Copy link
MemberAuthor

You can because you are a maintainer and I always enable that flag on PRs ;). Thanks for the fix!

@filmorfilmor marked this pull request as ready for reviewNovember 2, 2022 18:33
@lostmsu
Copy link
Member

missed a place in IR generator, should be working now

@filmorfilmor merged commitcfe1585 intopythonnet:masterNov 2, 2022
@filmorfilmor deleted the fix-derived-generic-interface branchNovember 2, 2022 18:39
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@filmor@lostmsu
[8]ページ先頭
©2009-2025 Movatter.jp