- Notifications
You must be signed in to change notification settings - Fork748
Allow decoders to decode Python types derived from primitives#1986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…s when target type is System.Objectuseful to be able to change what numpy.float64 is converted torelated topythonnet#1957this is an alternative topythonnet#1958
Looks good to me. I think this is a good stepping stone to eventually retire built-in primitive conversion in favour of using codecs for everything. |
1 task
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
When a Python instance needs to be converted to
System.Object, and the Python type is derived from one of the primitives (e.g.numpy.float64is derived fromfloat), allow a custom decoder to override the default behavior (which would have been converting toSystem.Double).Does this close any currently open issues?
It addresses the primary concern of#1957
Checklist
Check all those that are applicable and complete.