- Notifications
You must be signed in to change notification settings - Fork774
Implemented dynamic equality and inequality forPyObject instances#1849
Merged
lostmsu merged 1 commit intopythonnet:masterfromJun 30, 2022
Merged
Implemented dynamic equality and inequality forPyObject instances#1849lostmsu merged 1 commit intopythonnet:masterfrom
PyObject instances#1849lostmsu merged 1 commit intopythonnet:masterfrom
Conversation
fixed unhandled Python errors during comparison attemptsfixespythonnet#1848
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixed unhandled Python errors during comparison attempts
What does this implement/fix? Explain your changes.
For
==and!=operators in C# to use Python equalityPyObjectmust implementoperator ==andoperator !=. C# ignoresTryBinaryOperationimplementation for equality comparisons.The "also" part clears Python error when comparison can not be performed.
Does this close any currently open issues?
#1848
Checklist
Check all those that are applicable and complete.
CHANGELOG