- Notifications
You must be signed in to change notification settings - Fork756
Min/MaxSupportedVersion andIsSupportedVersion onPythonEngine#1798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
:/ I am puzzled. What does this change have to do with segfaults? Only on *nix? Ugh... |
Uh oh!
There was an error while loading.Please reload this page.
| @@ -127,6 +127,10 @@ public static string PythonPath | |||
| } | |||
| } | |||
| public static Version MinSupportedVersion => new(3, 7); | |||
| public static Version MaxSupportedVersion => new(3, 10, int.MaxValue, int.MaxValue); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Maybe something more "readable", like 999 instead of maxint?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I thought of that, but it won't work if there are builds of Python that use build number not as patch (e.g. patch .4), but in a Windows manner like .19041.365, or maybe doMaxSupportedVersionExclusive. Alternatively, we can only leave theIsSupportedVersion check and provide an error string in a separate property.
What do you think?
Just tested it as well, it only happens on Mono... |
filmor commentedMay 26, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Further observations:
|
Does this close any currently open issues?
fixes#1724
Checklist
Check all those that are applicable and complete.
CHANGELOG