Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Multiple fixes related to Dictionary.Keys bug#1786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lostmsu merged 5 commits intopythonnet:masterfromlosttech:bugs/KeyCollection
May 20, 2022

Conversation

lostmsu
Copy link
Member

@lostmsulostmsu commentedMay 7, 2022
edited
Loading

What does this implement/fix? Explain your changes.

This has individual commits for:

  1. bad name generation for nested classes which caused the type ofDictionary.Keys to be confused with theDictionary itself
  2. quality of life change, that allows castGeneric.IEnumerable(obj), which previously required the generic type argument to be specified. E.g.Generic.IEnumerable[String](obj) was required
  3. collection mixins now cast objects to corresponding interfaces when the interfaces are implemented privately

Does this close any currently open issues?

fixes#1785

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Updated theCHANGELOG

@Martin-Molinero

@filmor
Copy link
Member

Could you split part 2 out into a separate PR for discussion and add a few tests?

@lostmsu
Copy link
MemberAuthor

lostmsu commentedMay 9, 2022
edited
Loading

Do you have any specific concerns? The reason I made the quality of life change is to use it inIteratorMixin in the very next commit. E.g. it has a minimal test in that it is actually used internally. I don't think GitHubs allows PRs basing off other PRs.

@lostmsulostmsu added this to the3.0.0 milestoneMay 12, 2022
@lostmsulostmsu merged commit87d4db9 intopythonnet:masterMay 20, 2022
@lostmsulostmsu deleted the bugs/KeyCollection branchMay 20, 2022 00:15
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

Python handling of C# collection
2 participants
@lostmsu@filmor

[8]ページ先頭

©2009-2025 Movatter.jp