- Notifications
You must be signed in to change notification settings - Fork749
Disallow runtime shutdown when the Python error indicator is set#1780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…it may lead to unpredictable behavior
Couldn't we just clear it instead? |
@filmor that would be silent information loss. |
This way will probably lead to a lot more unwanted behaviour in that a program that ends with |
lostmsu commentedMay 4, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@filmor if they are at this point, they already have an unhandled exception. Generally speaking it is better to crash, than to try to close resources as you might persist a corrupted state and not get notified about it at all. |
Hmm, I'll tentatively agree with this, let's see whether someone complains :) |
What does this implement/fix? Explain your changes.
Shutting down runtime when the Python error indicator is set has unpredictable behavior.
Checklist
CHANGELOG