Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Disallow runtime shutdown when the Python error indicator is set#1780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

lostmsu
Copy link
Member

What does this implement/fix? Explain your changes.

Shutting down runtime when the Python error indicator is set has unpredictable behavior.

Checklist

@filmor
Copy link
Member

Couldn't we just clear it instead?

@lostmsu
Copy link
MemberAuthor

@filmor that would be silent information loss.

@filmor
Copy link
Member

This way will probably lead to a lot more unwanted behaviour in that a program that ends withShutdown will not have its resources closed if an error is still set (as it will just crash on this exception), or am I misunderstanding something?

@lostmsu
Copy link
MemberAuthor

lostmsu commentedMay 4, 2022
edited
Loading

@filmor if they are at this point, they already have an unhandled exception. Generally speaking it is better to crash, than to try to close resources as you might persist a corrupted state and not get notified about it at all.

@filmor
Copy link
Member

Hmm, I'll tentatively agree with this, let's see whether someone complains :)

@filmorfilmor merged commita80c685 intopythonnet:masterMay 4, 2022
@lostmsulostmsu deleted the disallow-shutdown-with-error-set branchMay 4, 2022 18:11
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@lostmsu@filmor

[8]ページ先頭

©2009-2025 Movatter.jp