- Notifications
You must be signed in to change notification settings - Fork749
Implement IConvertible on PyObject#1762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
.NET team now avoids |
See alsodotnet/runtime#62022 |
It doesn't look like there is an alternative yet, though, right? And I also don't think that they are actually going to drop the interface, they are just not extending it for new primitive types, which have no representation in Python anyway. |
@filmor the new |
| @@ -230,5 +230,7 @@ public string ToString(string format, IFormatProvider formatProvider) | |||
| using var _ = Py.GIL(); | |||
| return ToBigInteger().ToString(format, formatProvider); | |||
| } | |||
| public override TypeCode GetTypeCode() => TypeCode.Int64; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Generally, this is wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The docs are a bit unclear on this function. I used this as an "should almost always work" value, theInvalidCastException might still be thrown if the conversion fails. We could drop theGetTypeCode overrides entirely and just returnTypeCode.Object if you'd prefer that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I can't say for others, just for this one. Honestly, not sure if anyone ever uses this. Our own code assumesTypeCode.Int64 refers toSystem.Int64, so removing might be a good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm not sure I follow.GetTypeCode is supposed to be a hint that allows you to write aswitch like
switch(convertible.GetTypeCode()){caseTypeCode.Int64:returnConvert.ToInt64(convertible);}
It doesn't mean that the objectis aSystem.Int64 already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You seem to be correct on that. Still not sureInt64 is valid for this specific case, but float and string probably are. I am fine either way though. I don't think we will get people complaining about this returningInt64 any time soon.
Uh oh!
There was an error while loading.Please reload this page.
What does this implement/fix? Explain your changes.
Implements theIConvertible interface for
PyObjectinstances.Does this close any currently open issues?
Shouldfix#1755.
Any other comments?
...
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG