- Notifications
You must be signed in to change notification settings - Fork749
Clear weakref list when reflected object is destroyed#1758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
this was missed whenpythonnet#1267 was superseded
MemberAuthor
lostmsu commentedApr 9, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Also@amos402 if you have time. This reintroduces bits of your old PR from Oct 2020. |
filmor approved these changesApr 9, 2022
lostmsu added a commit to losttech/pythonnet that referenced this pull requestApr 9, 2022
According to official documentation for defining extension types, if they are to support weak references, they must clear weak reference list associated with the instance in tp_clear.Extension types were missed inpythonnet#1758 (50da522 )
lostmsu added a commit to losttech/pythonnet that referenced this pull requestApr 9, 2022
According to official documentation for defining extension types, if they are to support weak references, they must clear weak reference list associated with the instance in tp_clear.Extension types were missed inpythonnet#1758 (50da522 )
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
According toofficial documentation for defining extension types, if they are to support weak references, they must clear weak reference list associated with the instance in
tp_clear.This was missed when#1267 was superseded.
P.S. without the fix corresponding test would crash with segfault due to an attempt to dereference an object that no longer exists via a weak reference to it.
Does this close any currently open issues?
N/A
Checklist
Check all those that are applicable and complete.