Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Temporary fix method binder for out parameters#1672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lostmsu merged 7 commits intopythonnet:masterfrommcneel:pr/outparamfix
Jan 14, 2022

Conversation

eirannejad
Copy link
Contributor

@eirannejadeirannejad commentedJan 13, 2022•
edited
Loading

What does this implement/fix? Explain your changes.

Current method binder code needs cleanup. There is an active issue with pythonnet failing to find the appropriate overload when the method signature includesout parameters e.g.SomeMethod(int a, out int b). Current workaround is to call the method by providing bogus value for theout parameter e.g.SomeMethod(1, 0) instead ofSomeMethod(1)

This PR pushes a temporary fix for this problem until the binder code is cleaned up. The change is intentionally minimal.

Does this close any currently open issues?

Not sure. Can not find anything related to this by looking at open issue titles

Any other comments?

No

Checklist

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself toAUTHORS
  • Updated theCHANGELOG

@eirannejadeirannejad changed the titletemp fixed method binder for out paramsTemporary fix method binder for out parametersJan 13, 2022
@lostmsu
Copy link
Member

@eirannejad, please add a test or two to cover the new code.

eirannejad reacted with thumbs up emoji

existing tests are passing bogus values to force matching the method signaturethese tests should pass with the recent method binder fix, without passing the bogus values
Copy link
Member

@lostmsulostmsu left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please, keep old test scenarios unless they are actually not supported anymore.

@eirannejad
Copy link
ContributorAuthor

(I'm a bit new to Github review/request change process. I apologize in advance if I clicked too many things)

@lostmsulostmsu merged commitf69753c intopythonnet:masterJan 14, 2022
@filmor
Copy link
Member

@eirannejad We'd need you to sign the .NET Foundation CLA:https://cla.dotnetfoundation.org/pythonnet/pythonnet

@lostmsu Please have an eye on this for first-time contributors until the CLA bot is fixed.

@eirannejadeirannejad deleted the pr/outparamfix branchJanuary 14, 2022 17:17
@eirannejad
Copy link
ContributorAuthor

@filmor@lostmsu Signed the CLA. Thanks for merging this.

filmor reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@lostmsulostmsuAwaiting requested review from lostmsu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@eirannejad@lostmsu@filmor
[8]ページ先頭
©2009-2025 Movatter.jp