- Notifications
You must be signed in to change notification settings - Fork749
Fixed accessing partially overriden properties from Python#1650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
+103 −9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
a41a153 to84102cdCompare…etMethod would not return base non-overriden accessor for a partially overriden propertybecause of that when constructing PropertyObject we scan base classes to find base accessor (if any)this might have performance implications due to replacement of PropertyInfo.GetValue with getter.Invoke (not tested)fixespythonnet#1455
84102cd toa07f00cCompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
.NET
PropertyInfo.GetMethodwould not return base non-overridden accessor for a partially overridden property (e.g. only setter overridden)Because of that when constructing
PropertyObjectwe scan base classes to find base accessor (if any).Does this close any currently open issues?
fixes#1455
Any other comments?
This might have performance implications due to replacement of
PropertyInfo.GetValuewithgetter.Invoke(not tested)Also in the change
No need to serialize accessors - they can be reconstructed from the
PropertyInfoChecklist
Check all those that are applicable and complete.