Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Include NonCopyableAnalyzer#1615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
filmor wants to merge4 commits intopythonnet:masterfromfilmor:include-analyzer

Conversation

filmor
Copy link
Member

  • Include NonCopyableAnalyzer
  • Fix analyzer for array creation handling and deactivate return handling

What does this implement/fix? Explain your changes.

...

Does this close any currently open issues?

...

Any other comments?

...

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself toAUTHORS
  • Updated theCHANGELOG

@lostmsu
Copy link
Member

I don't think including analyzer in pythonnet is a good idea.

Also, simply disabling return analysis is not correct. It needs to be counted as a "move".

@filmor
Copy link
MemberAuthor

Well, we have to do something :)

  1. Somehow your fork's nuget is not visible on Nuget.org, I couldn't find the sources yesterday either
  2. The last version published (0.7.0-m04?) doesn't have the fix for array creation, so it throws warnings without end for me
  3. Do you intend to upsteam your changes? Do you use the analyzer somewhere else?

@lostmsu
Copy link
Member

lostmsu commentedNov 14, 2021
edited
Loading

Yeah, it is in my personal repository, dev branch:https://github.com/lostmsu/NonCopyableAnalyzer/commits/dev

I guess upstreaming is an option. It just took extra time to upstream.

Let's keep it there or make a fork inpythonnet org.

@filmor
Copy link
MemberAuthor

The reason why I'd like to include it here is that I don't actually want to maintain it more than necessary to keep it working within this project (as in: I (myself) don't want to publish a nuget package and react on other people using it). If you want to do that, that's fine by me, but please publish an updated version then (with the array creation fix).

@lostmsu
Copy link
Member

@filmor I was actually planning to upstream all the changes in that package. We are only using a fork because I did not get to doing it last time. My plan is (once I get to it):

  1. make the changes in my fork
  2. publish an updated personal version of NuGet
  3. consume it from this repository
  4. upstream changes to the originalNonCopyableAnalyzer repo
  5. once upstream publishes new version, switch this repo to it

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@filmor@lostmsu

[8]ページ先頭

©2009-2025 Movatter.jp