- Notifications
You must be signed in to change notification settings - Fork749
Include NonCopyableAnalyzer#1615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
I don't think including analyzer in pythonnet is a good idea. Also, simply disabling return analysis is not correct. It needs to be counted as a "move". |
Well, we have to do something :)
|
lostmsu commentedNov 14, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Yeah, it is in my personal repository, dev branch:https://github.com/lostmsu/NonCopyableAnalyzer/commits/dev I guess upstreaming is an option. It just took extra time to upstream. Let's keep it there or make a fork in |
The reason why I'd like to include it here is that I don't actually want to maintain it more than necessary to keep it working within this project (as in: I (myself) don't want to publish a nuget package and react on other people using it). If you want to do that, that's fine by me, but please publish an updated version then (with the array creation fix). |
@filmor I was actually planning to upstream all the changes in that package. We are only using a fork because I did not get to doing it last time. My plan is (once I get to it):
|
What does this implement/fix? Explain your changes.
...
Does this close any currently open issues?
...
Any other comments?
...
Checklist
Check all those that are applicable and complete.
AUTHORS
CHANGELOG