- Notifications
You must be signed in to change notification settings - Fork749
Fixed recursive dependency in clr module initialization#1602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
lostmsu merged 1 commit intopythonnet:masterfromlosttech:bugs/GlobalClassDerivedFromEnumerableOct 16, 2021
Merged
Fixed recursive dependency in clr module initialization#1602
lostmsu merged 1 commit intopythonnet:masterfromlosttech:bugs/GlobalClassDerivedFromEnumerableOct 16, 2021
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…a public class that implements IEnumerable in global namespacepythonnet#1601the fix is to delay updating clr module dict with contents of .NET namespaces until after our internal modules are loaded
filmor approved these changesOct 16, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
There was a recursive dependency in
clrmodule initialization when a public class that implementsIEnumerableexists in the global namespace.The fix is to delay updating
clrmodule dict with contents of .NET namespaces until after our internal modules are loaded because .NET classes might depend on our internal modules to be initialized. In particular, any class implementingIEnumerableneedsIterableMixinfromcollections.pyDoes this close any currently open issues?
#1601
Checklist
Check all those that are applicable and complete.