NotificationsYou must be signed in to change notification settings
Fork761
Star5.2k

Make .NET objects that have`call` method callable from Python#1589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

filmor merged 1 commit intopythonnet:masterfromlosttech:callable

Oct 14, 2021

Merged

Make .NET objects that have`call` method callable from Python#1589

filmor merged 1 commit intopythonnet:masterfromlosttech:callable

Oct 14, 2021

Conversation

Copy link

Member

lostmsu commentedOct 6, 2021

What does this implement/fix? Explain your changes.

Implemented by addingtp_call toClassBase, that uses reflection to find__call__ methods in .NET, and falls back to invoking__call__ method from Python base classes.

Does this close any currently open issues?

Implements#890

Any other comments?

This is an amalgamation ofd46878c,5bb1007, and960457f fromhttps://github.com/losttech/pythonnet

Checklist

Check all those that are applicable and complete.

Make sure to include one or more tests for your change
If an enhancement PR, please create docs and at best an example
Updated theCHANGELOG

lostmsu added the enhancement label

Oct 6, 2021

lostmsu added this to the3.0.0 milestone

Oct 6, 2021

lostmsu force-pushed thecallable branch 4 times, most recently fromd0f8cdc to00cca0fCompare

October 7, 2021 00:04

lostmsu requested a review fromfilmor

October 7, 2021 00:09

make .NET objects that have __call__ method callable from Python

873fe54

Implemented by adding tp_call to ClassBase, that uses reflection to find __call__ methods in .NETfixespythonnet#890this is an amalgamation ofd46878c,5bb1007, and960457f fromhttps://github.com/losttech/pythonnet