What does this implement/fix? Explain your changes.

Prior to this changePyObject.GetAttr(name, default) would ignore any exceptions, including ones unrelated to missing attribute. For example (hypothetically)PyObject is a file, and you callfile.GetAttr("len", 0), it would return0 on I/O error even thoughfile object actually haslen attribute.

Remarks

I marked the method obsolete, as even now when we restrict ignored errors toAttributeError and derived types, the behavior of this method still going to be misleading in some scenarios. For example,

classRaisesAttrErr:@propertydefprop(self):raiseAttributeErrorclassOK:def__init__(self,impl):self._impl=impl@propertydefexisting_prop(self):returnself._impl.prop

PythonEngine.Eval("OK(RaisesAttrErr())").GetAttr("existing_prop",0)// returns 0 despite existing_prop actually existing -^ in OK

Does this close any currently open issues?

fixes#1036

Checklist

Check all those that are applicable and complete.

• Make sure to include one or more tests for your change
• Updated theCHANGELOG