- Notifications
You must be signed in to change notification settings - Fork750
RaiseBadPythonDllException instead of confusingTypeLoadException whenPythonDLL was not configured properly#1577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
lostmsu merged 1 commit intopythonnet:masterfromlosttech:less-confusing-delegates-loadingSep 29, 2021
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…ption) instead of confusing TypeLoadException when PythonDLL was not configured properly
filmor approved these changesSep 29, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This handles failure to load internal
Delegatestype due to misconfiguredPythonDLL, which used to raiseTypeLoadExceptionwhoseInnerExceptionwould give users the details. Unfortunately, some users do not bother to go as far as to look into theInnerException, and instead go straight to GitHub and report "a bug".This change handles that
TypeLoadExceptionand rethrows it asBadPythonDllExceptionin major entry points, which makes looking intoInnerExceptionunnecessary, hopefully reducing the number of "bugs"Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG