Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

PyScope/PyModule API cleanup#1569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lostmsu merged 1 commit intopythonnet:masterfromlosttech:pyscope-cleanup
Sep 30, 2021

Conversation

lostmsu
Copy link
Member

@lostmsulostmsu commentedSep 23, 2021
edited
Loading

  • removedPyScopeManager
  • mergedPyScope intoPyModule (everyPyScope was a Python module anyway)
  • minor behavioral changes

Does this close any currently open issues?

This is part of3.0 API cleanup, targeting#1390

Checklist

@lostmsulostmsu added this to the3.0.0 milestoneSep 24, 2021
@lostmsu
Copy link
MemberAuthor

@filmor can you take a look at this one at least in principle?

@lostmsulostmsuforce-pushed thepyscope-cleanup branch 2 times, most recently from21389d8 to8e3cb3cCompareSeptember 28, 2021 06:02
@filmor
Copy link
Member

I'm okay with this one, though for a slight backwards-compatibility I'd propose we add[Obsolete]public class PyScope : PyModule with both public constructors copied. Is there any particular reason why you renamed the file frompymodule tomodule? Matching the filename makes sense to me.

@lostmsu
Copy link
MemberAuthor

lostmsu commentedSep 30, 2021
edited
Loading

@filmor re: filename. Without renaming the file, diff is larger (that's because the file has more code fromPyScope than fromPyModule). Diff tools assume pyscope is deleted, and pymodule gets tons of new stuff. When file is renamed, they properly detect that is more a rename of pyscope with minor stuff from PyModule, then a rename of pymodule with minor stuff from PyScope.

@lostmsu
Copy link
MemberAuthor

lostmsu commentedSep 30, 2021
edited
Loading

@filmor re:PyScope. The originalPyScope did not have any public constructors. E.g. there's no point in keeping it.

@filmor
Copy link
Member

It had public static functions, though (and that's also how I always used it). So you can probably ignore the constructors, but deriving still makes sense.

@lostmsu
Copy link
MemberAuthor

@filmor I don't see any public static functions on oldPyScope. There was a single factory methodPy.Scope() and I preserved that one.

removed PyScopeManagermerged PyScope into PyModuleminor behavioral changes
@lostmsulostmsu merged commit66716db intopythonnet:masterSep 30, 2021
@lostmsulostmsu deleted the pyscope-cleanup branchSeptember 30, 2021 19:33
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@filmorfilmorfilmor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

2 participants
@lostmsu@filmor

[8]ページ先頭

©2009-2025 Movatter.jp