- Notifications
You must be signed in to change notification settings - Fork749
PyScope
/PyModule
API cleanup#1569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@filmor can you take a look at this one at least in principle? |
Uh oh!
There was an error while loading.Please reload this page.
21389d8
to8e3cb3c
CompareI'm okay with this one, though for a slight backwards-compatibility I'd propose we add |
lostmsu commentedSep 30, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@filmor re: filename. Without renaming the file, diff is larger (that's because the file has more code from |
lostmsu commentedSep 30, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@filmor re: |
It had public static functions, though (and that's also how I always used it). So you can probably ignore the constructors, but deriving still makes sense. |
@filmor I don't see any public static functions on old |
removed PyScopeManagermerged PyScope into PyModuleminor behavioral changes
Uh oh!
There was an error while loading.Please reload this page.
PyScopeManager
PyScope
intoPyModule
(everyPyScope
was a Python module anyway)Does this close any currently open issues?
This is part of3.0 API cleanup, targeting#1390
Checklist
CHANGELOG