- Notifications
You must be signed in to change notification settings - Fork749
Disable implicit conversions that might lose information#1568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
631b019 toc97e5abComparefilmor approved these changesSep 24, 2021
Uh oh!
There was an error while loading.Please reload this page.
PyInt -> int32.NET arrays and collections -> Python list (due to mutability)
2e8cd3f tob2e6d4eComparelostmsu commentedSep 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
A few minor isssues
| { | ||
| if (setError) | ||
| { | ||
| Exceptions.SetError(ex.InnerException); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should be justSetError(ex)
Comment on lines 363 to 364
| return true; | ||
| } | ||
| // shouldn't happen | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fallback branch should be added.
lostmsu added a commit to losttech/pythonnet that referenced this pull requestSep 27, 2021
lostmsu added a commit to losttech/pythonnet that referenced this pull requestSep 27, 2021
lostmsu added a commit that referenced this pull requestSep 27, 2021
lostmsu added a commit to losttech/pythonnet that referenced this pull requestOct 2, 2021
… point typesarbitrary Python objects are no longer implicitly converted to .NET bool typethis is a continuation ofpythonnet#1568
3 tasks
lostmsu added a commit to losttech/pythonnet that referenced this pull requestOct 2, 2021
… point typesarbitrary Python objects are no longer implicitly converted to .NET bool typethis is a continuation ofpythonnet#1568
lostmsu added a commit to losttech/pythonnet that referenced this pull requestOct 2, 2021
… point typesarbitrary Python objects are no longer implicitly converted to .NET bool typethis is a continuation ofpythonnet#1568
lostmsu added a commit to losttech/pythonnet that referenced this pull requestOct 2, 2021
… point typesarbitrary Python objects are no longer implicitly converted to .NET bool typethis is a continuation ofpythonnet#1568
lostmsu added a commit to losttech/pythonnet that referenced this pull requestOct 2, 2021
… point typesarbitrary Python objects are no longer implicitly converted to .NET bool typethis is a continuation ofpythonnet#1568
lostmsu added a commit that referenced this pull requestOct 5, 2021
… point typesarbitrary Python objects are no longer implicitly converted to .NET bool typethis is a continuation of#1568
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
What does this implement/fix? Explain your changes.
This removes the following conversions:
PyInt->int32(when trying to convert toobjectonly).NET arrays and collections -> Python
list(due to mutability)Additionally,
PyObjectno longer implementsIEnumerable<PyObject>, as not all python objects are iterable. Instead, a new classPyIterableis added.Checklist
CHANGELOG