Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Cleaning up public API#1557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lostmsu merged 1 commit intopythonnet:masterfromlosttech:public-API-cleanup
Sep 30, 2021
Merged

Conversation

lostmsu
Copy link
Member

@lostmsulostmsu commentedSep 15, 2021•
edited
Loading

This handles#1539

Deleted:

  • PyLong
  • PyAnsiString
  • a few internal overloads to convert between Python integer type and .NET int types

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Updated theCHANGELOG

@lostmsulostmsuforce-pushed thepublic-API-cleanup branch 7 times, most recently from17b4a04 to550fcafCompareSeptember 21, 2021 18:30
@lostmsulostmsu added this to the3.0.0 milestoneSep 24, 2021
@lostmsu
Copy link
MemberAuthor

@filmor any other comments?

@@ -76,7 +76,7 @@ private Type GetDispatcher(Type dtype)
var cc = CallingConventions.Standard;
Type[] args = { ptrtype, typetype };
ConstructorBuilder cb = tb.DefineConstructor(ma, cc, args);
ConstructorInfo ci = basetype.GetConstructor(args);
ConstructorInfo ci = basetype.GetConstructor(BindingFlags.Instance | BindingFlags.NonPublic, null,args, null);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Does this change behaviour?

Copy link
MemberAuthor

@lostmsulostmsuSep 30, 2021•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Users can no longer construct their own instances ofDispatcher manually (which is the goal of the change).

I doubt anyone did that anyway, it is very obscure.

@lostmsulostmsu merged commit8846fd2 intopythonnet:masterSep 30, 2021
@lostmsulostmsu deleted the public-API-cleanup branchSeptember 30, 2021 18:43
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@filmorfilmorfilmor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

2 participants
@lostmsu@filmor
[8]ページ先頭
©2009-2025 Movatter.jp