NotificationsYou must be signed in to change notification settings
Fork749
Star5.1k

Call tp_clear of base unmanaged type#1541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

lostmsu merged 1 commit intopythonnet:masterfromlosttech:bugs/MemLeak-CatchingExceptions

Sep 14, 2021

Merged

Call tp_clear of base unmanaged type#1541

lostmsu merged 1 commit intopythonnet:masterfromlosttech:bugs/MemLeak-CatchingExceptions

Sep 14, 2021

Conversation

Copy link

Member

lostmsu commentedSep 5, 2021

What does this implement/fix? Explain your changes.

Callstp_clear (if any) of base unmanaged type when a reflected CLR object instance is cleared.

Does this close any currently open issues?

#1476

Any other comments?

C# exceptions inherit from PythonBaseException class, which hastp_clear. Prior to this change it was not called when Python deallocated them leaving dangling references toBaseException.args andBaseException.__cause__.

Checklist

Check all those that are applicable and complete.

Make sure to include one or more tests for your change

call tp_clear (if any) of base unmanaged type when a reflected CLR ob…

c544eaa

…ject instance is clearedfixespythonnet#1476 : C# exceptions inherit from Python BaseException class, which has tp_clear. Prior to this change it was not called, leaving dangling references to BaseException.args and BaseException.__cause__.call tp_clear of base unmanaged type when a reflected CLR object instance is clearedfixespythonnet#1476 : C# exceptions inherit from Python BaseException class, which has tp_clear. Prior to this change it was not called, leaving dangling references to BaseException.args and BaseException.__cause__.