- Notifications
You must be signed in to change notification settings - Fork749
Fixed double call toPyType_Ready in CLR MetaType'stp_new#1486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
filmor merged 1 commit intopythonnet:masterfromlosttech:bugs/PythonInheritsDotNet_DoubleTypeReadyJul 7, 2021
Merged
Fixed double call toPyType_Ready in CLR MetaType'stp_new#1486
filmor merged 1 commit intopythonnet:masterfromlosttech:bugs/PythonInheritsDotNet_DoubleTypeReadyJul 7, 2021
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
….tp_new`. It should have not been allowed in the first place, but we accidentally cleared `Ready` from `tp_flags`. Instead, we will extend `tp_flags` and call `PyType_Modified` at the end of CLR MetaType.tp_new
filmor approved these changesJul 7, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
It should have not been allowed in the first place, but we accidentally cleared
Readyfromtp_flags. Instead, we will extendtp_flagsand callPyType_Modifiedat the end of CLR MetaType.tp_newDoes this close any currently open issues?
No
Any other comments?
This change is required for the upcoming feature, that allows setting custom base type for reflected .NET classes (as seen from Python).