Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add a failing test for Unicode conversion#1467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lostmsu merged 8 commits intopythonnet:masterfrompkese:master
Jun 11, 2021

Conversation

pkese
Copy link
Contributor

@pkesepkese commentedJun 8, 2021•
edited
Loading

What does this implement/fix? Explain your changes.

A failing test for#1466

Does this close any currently open issues?

No, just analyzes failure case.

Any other comments?

See#1466

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself toAUTHORS
  • Updated theCHANGELOG

@dnfadmin
Copy link

dnfadmin commentedJun 8, 2021•
edited
Loading

CLA assistant check
All CLA requirements met.

@pkesepkese mentioned this pull requestJun 8, 2021
@lostmsu
Copy link
Member

@filmor requested some minor tweaks

char* codePoints = (char*)PyBytes_AsString(p.DangerousGetAddress());
var bytesPtr = p.DangerousGetAddress();
int bytesLength = (int)Runtime.PyBytes_Size(bytesPtr);
char* codePoints = (char*)PyBytes_AsString(bytesPtr);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

NIT: better add overload forPyBytes_AsString that takesBorrowedReference. This would remove unnecessary call toDangerousGetAddress above.

@filmor
Copy link
Member

@lostmsu Can you reproduce the segfault on Python 3.9?

@lostmsu
Copy link
Member

@filmor it did not fail on rerun. I think we can merge this in, and investigate if it will reappear.

@lostmsulostmsu merged commit12027ad intopythonnet:masterJun 11, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@lostmsulostmsulostmsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@pkese@dnfadmin@lostmsu@filmor
[8]ページ先頭
©2009-2025 Movatter.jp