- Notifications
You must be signed in to change notification settings - Fork749
Prevent stack overflow when an encoder is registered from Python#1429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
lostmsu merged 3 commits intopythonnet:masterfromlosttech:bugs/StackOverflow_with_raw_list_encoderMar 31, 2021
Merged
Prevent stack overflow when an encoder is registered from Python#1429
lostmsu merged 3 commits intopythonnet:masterfromlosttech:bugs/StackOverflow_with_raw_list_encoderMar 31, 2021
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
3208bd2 toaa5e504Compare(stack overflow trying to pass `System.Type` to `CanEncode`)
Without this restriction encoders created in Python cause stack overflow due to repeated attempts to pass `System.Type` instance to `CanDecode`, which requires encoding the instance of `System.Type`, et. ceterafixespythonnet#1427
6b87b38 to8045b5fCompare… to known issue with custom codes + engine restartspythonnet#1256
8045b5f to0d33a90CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
What does this implement/fix? Explain your changes.
This disables ability to register encoders for
System.Type.Without this restriction encoders created in Python cause stack overflow due to repeated attempts to pass
System.Typeinstance toCanDecode, which requires encoding the instance ofSystem.Type.Does this close any currently open issues?
#1427
Checklist
Check all those that are applicable and complete.
CHANGELOG