- Notifications
You must be signed in to change notification settings - Fork748
Try libdl.so.2 on Linux before libdl.so#1425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
also refactored LibraryLoader to share code between Linux and Macfixespythonnet#1422
filmor approved these changesMar 25, 2021
m-rossi added a commit to m-rossi/pythonnet-feedstock that referenced this pull requestAug 15, 2021
The idea is borrowed frompythonnet/pythonnet#1425
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Newer Linux systems (Ubuntu, CentOS) do not contain
libdl.soby default: they switched tolibdl.so.2. So we try it first.Also refactored
LibraryLoaderto share code between Linux and Mac (really any POSIX systems).Does this close any currently open issues?
#1422