NotificationsYou must be signed in to change notification settings
Fork749
Star5.1k

Removed unnecessary dictionary initialization in CLRObject#1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

lostmsu wants to merge0 commits intopythonnet:masterfromlosttech:dont-alloc-dict-for-clrobject

Closed

Removed unnecessary dictionary initialization in CLRObject#1413

lostmsu wants to merge0 commits intopythonnet:masterfromlosttech:dont-alloc-dict-for-clrobject

Conversation

Copy link

Member

lostmsu commentedMar 10, 2021•
edited
Loading

I don't see any reason for it to be present. The code does not have any associated comments, and I was not able to hit it running our tests. Any proper access toob_dict should be going throughPyObject_GenericGetDict, which initializesob_dict if necessary.