Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Re-enable the domain reload tests#1404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lostmsu merged 7 commits intopythonnet:masterfromUnity-Technologies:fix-1403
May 3, 2021

Conversation

BadSingleton
Copy link
Contributor

@BadSingletonBadSingleton commentedMar 1, 2021•
edited
Loading

Fixes issue#1403

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself toAUTHORS
  • Updated theCHANGELOG

@BadSingletonBadSingleton changed the titleMake the domain reload tests run againRe-enable the domain reload testsMar 1, 2021
Add `src/domain_tests` to `testpaths` in pyproject.toml
@filmor
Copy link
Member

Sorry about that. Could you please add these as separate actions, though, instead of adding them to the normal testing? They are only relevant on Mono and .NET Framework anyhow.

@BadSingleton
Copy link
ContributorAuthor

I think adding them as a separate action is not optimal, as devs will have to run pytest specifying explicitly the domain tests. I added pytest filtering instead

@BadSingleton
Copy link
ContributorAuthor

I think the timeouts are false positive. The domain tests takes about 1:15m to execute.

@lostmsulostmsu merged commit33d771c intopythonnet:masterMay 3, 2021
@BadSingletonBadSingleton deleted the fix-1403 branchMay 4, 2021 13:20
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@BadSingleton@filmor@lostmsu
[8]ページ先頭
©2009-2025 Movatter.jp