Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Remove Utf8Marshaler, set PyScope base class to PyObject, added PyModule#1391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
filmor merged 4 commits intopythonnet:masterfromlosttech:cleanup/21-02-19
Feb 26, 2021

Conversation

lostmsu
Copy link
Member

Also allowBorrowedReference == null comparison.

@lostmsulostmsuforce-pushed thecleanup/21-02-19 branch 12 times, most recently fromcbfd65c toad5343dCompareFebruary 21, 2021 06:14
@@ -742,9 +707,10 @@ public static KeywordArguments kw(params object[] kv)
return dict;
}

[Obsolete("Use PyModule.Import")]
public static PyObject Import(string name)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I wouldn't obsolete this one right now. HavingPy. as a central entry-point has merit.

Copy link
MemberAuthor

@lostmsulostmsuFeb 24, 2021•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@filmor Perhaps we should movePy class into its own file 🤣
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

:D
Yep, sorry for the inconsistency. I'd like to obsoletePythonEngine for the most part and collect entry points inPy.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Removed this[Obsolete], added a new issue to movePy out.

@lostmsulostmsu requested a review fromfilmorFebruary 24, 2021 18:12
@filmorfilmor merged commit5bcd708 intopythonnet:masterFeb 26, 2021
@lostmsulostmsu deleted the cleanup/21-02-19 branchMarch 31, 2021 20:26
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@filmorfilmorAwaiting requested review from filmor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@lostmsu@filmor
[8]ページ先頭
©2009-2025 Movatter.jp