- Notifications
You must be signed in to change notification settings - Fork774
Remove Utf8Marshaler, set PyScope base class to PyObject, added PyModule#1391
Remove Utf8Marshaler, set PyScope base class to PyObject, added PyModule#1391filmor merged 4 commits intopythonnet:masterfrom
Conversation
cbfd65c toad5343dCompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
src/runtime/pythonengine.cs Outdated
| } | ||
| [Obsolete("Use PyModule.Import")] | ||
| public static PyObject Import(string name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I wouldn't obsolete this one right now. HavingPy. as a central entry-point has merit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@filmor Perhaps we should movePy class into its own file 🤣
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
:D
Yep, sorry for the inconsistency. I'd like to obsoletePythonEngine for the most part and collect entry points inPy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Removed this[Obsolete], added a new issue to movePy out.
changed PyScope to inherit from PyObject
Also allow
BorrowedReference == nullcomparison.