- Notifications
You must be signed in to change notification settings - Fork749
Monthly NuGet release previews#1380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Does this really need to run tests? IMHO it's perfectly fine to keep this as simple as possible, i.e. to just run |
a1232da to7c205d6CompareI think it is better to keep tests to avoid non-functional releases. |
| @@ -38,6 +38,9 @@ indent_style = tab | |||
| charset = utf-8 | |||
| insert_final_newline = true | |||
| [Python.Runtime.csproj] | |||
| charset = latin1 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is an odd choice for XML, is this intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Without this Visual Studio tends to add UTF-8 BOM header to solution, leading to PRs with the entire file replaced. It simply ignoresutf-8 above.
.github/workflows/nuget-preview.yml Outdated
| - name: Publish NuGet | ||
| run: dotnet nuget push --api-key ${NUGET_KEY} | ||
| env: | ||
| NUGET_KEY: ${{ secrets.NUGET_MONTHLY }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think this way you'll leak the key.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't think so, but the reason I had to try to add this turned out to be bogus: it was not picked up, because PR was from my fork. I moved the PR branch into this repository instead, now it is getting picked up correctly. See#1381
So I reverted to using${{ secrets.NUGET_MONTHLY }} directly
Superseded by#1381 |
What does this implement/fix? Explain your changes.
This generates monthly release previews on NuGet using GitHub actions
Does this close any currently open issues?
#1379