- Notifications
You must be signed in to change notification settings - Fork748
ParameterInfo.Name needs to be checked for null before usage#1375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This occured in trying to use F# code from Python. As the `.Name` propertyreturns `null`, `ContainsKey` fails.Related documentation:https://docs.microsoft.com/en-us/dotnet/api/system.reflection.parameterinfo.name
Can you add a test? |
I see#1374 |
This occured in trying to use F# code from Python. As the `.Name` propertyreturns `null`, `ContainsKey` fails.Related documentation:https://docs.microsoft.com/en-us/dotnet/api/system.reflection.parameterinfo.name
noambonnieclear commentedFeb 11, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I tried testing this with the latest 2.5.2 release. Could it be that there was something wrong with the distribution of the package? We checked on multiple environments and it looks like when we install 2.5.2 we still get 2.5.1. Really odd but we're running out of ideas of what we might be doing wrong for a straight forward upgrade... :-) Also tried fresh installs... For example:
|
It's possible that I missed one version string somewhere, sorry about that. The process on the backports branch is completely manual. |
noambonnieclear commentedFeb 11, 2021
Thank you@filmor - what's the path forward? is it going to be re-released as 2.5.2 or changed to 2.5.3? i.e. - will I get notified of a new release when this is corrected? |
noambonnieclear commentedFeb 11, 2021
I don't intend to do a 2.5.3 release just for this. 2.5 is frozen, only patches for regressions are backported. Work is happening on |
Uh oh!
There was an error while loading.Please reload this page.
What does this implement/fix? Explain your changes.
This occured in trying to use F# code from Python. As the
.Name
property returnsnull
,ContainsKey
fails.Does this close any currently open issues?
I don't think so.
Any other comments?
Related documentation:https://docs.microsoft.com/en-us/dotnet/api/system.reflection.parameterinfo.name
I don't know if there is a way to create a C# method without a parameter name. I'll try to set up a few simple F# test-cases in the future in a separate PR (follow-up ticket:#1374).
Checklist
Check all those that are applicable and complete.
AUTHORS
CHANGELOG