- Notifications
You must be signed in to change notification settings - Fork748
Disable implicit conversion from PyFloat to uint64#1362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
src/runtime/converter.cs Outdated
Comment on lines 702 to 704
| if (Runtime.PyObject_TYPE(value) != Runtime.PyLongType) | ||
| { | ||
| op = Runtime.PyNumber_Long(value); | ||
| if (op == IntPtr.Zero) | ||
| { | ||
| goto convert_error; | ||
| } | ||
| goto type_error; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think this can be skipped alltogether.https://docs.python.org/3.8/c-api/long.html#c.PyLong_AsUnsignedLongLong already checks the type.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Fixes an oversight in#1343 that allows PyFloat to continue being converted to uint64.
Does this close any currently open issues?
Fixes the test failures in#1361
Any other comments?
...
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG