- Notifications
You must be signed in to change notification settings - Fork748
TestPythonEngineProperties.SetPythonPath avoids corrupting the module search path for later tests#1336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
… search path for later tests
lostmsu left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This seems fine. However, if you wanted this change to add a C# runner for Python tests, I suggest you turn the runner into a separate project file instead.
I'd also suggest to use something likehttps://stackoverflow.com/questions/866816/dynamically-create-tests-in-nunit to have the test display as individual tests.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
What does this implement/fix? Explain your changes.
Improves the test suite of Python.NET
Does this close any currently open issues?
Fixes#1335
Any other comments?
This change is not visible to the end user so it doesn't make sense to add it to the CHANGELOG.
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG