NotificationsYou must be signed in to change notification settings
Fork750
Star5.1k

Add very simple example editor#1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

gpetrou wants to merge1 commit intopythonnet:masterfromgpetrou:Editor

Closed

Add very simple example editor#1333

gpetrou wants to merge1 commit intopythonnet:masterfromgpetrou:Editor

Conversation

Copy link

Contributor

gpetrou commentedDec 19, 2020•
edited
Loading

What does this implement/fix? Explain your changes.

I am doing my first steps in Python .NET and I created a small editor project in order to test the library. Looking for information on how to redirect output to C# and interrupt execution, I saw that other people had the same questions. So, I thought of making this small contribution to get other people started with this library instead of looking for the same things as I did.

Does this close any currently open issues?

Any other comments?

Checklist

Check all those that are applicable and complete.

Make sure to include one or more tests for your change
If an enhancement PR, please create docs and at best an example
Add yourself toAUTHORS
Updated theCHANGELOG

Copy link

dnfadmin commentedDec 19, 2020•
edited
Loading

All CLA requirements met.

gpetrou force-pushed theEditor branch 4 times, most recently from67474eb to9889ff1Compare

December 19, 2020 14:57

Copy link

Member

filmor commentedDec 20, 2020

Hi,

First, thank you for your contribution. To me, these really look like two separate PRs, one for theInterrupt function and one for theEditor example.

Regarding theInterrupt:

This requires a test
Strictly, the thread-id attribute isunsigned only for Python >= 3.7 and we still support 3.6
Also, since the original type islong, the "correct" type is(U)IntPtr on everything but Windows
(Not quite sure how far we have to go there compatibility-wise, the current implementation could be fine for the usual thread IDs)
Maybe we should just expose the API function directly (i.e.RaiseInPythonThread onException objects or so) and makeInterrupt use that

Regarding theEditor:

Should be in its own PR
Should not be insrc/
I didn't read the actual code yet, but a self-contained example like this is definitely a useful addition.